Update handle fetch algorithm step to consider null of source #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@yoshisatoyanagisawa Could you take a look at this and see if the change makes sense? Thanks! |
docs/index.bs
Outdated
| 1. Wait until |queue| is not empty. | ||
| 1. Return the result of [=dequeue=] |queue|. | ||
| 1. Assert: |source| is "{{RouterSourceEnum/fetch-event}}" | ||
| 1. if |source| is non-null, then: |
Collaborator
There was a problem hiding this comment.
Nit but please starts with a capital letter.
yoshisatoyanagisawa
approved these changes
May 7, 2025
Collaborator
yoshisatoyanagisawa
left a comment
yoshisatoyanagisawa
left a comment
There was a problem hiding this comment.
lgtm
Thank you!
github-actions bot
added a commit
that referenced
this pull request
May 7, 2025
SHA: b7bbcea Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
May 7, 2025
SHA: b7bbcea Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handle fetch algorithm to check the nullness of Get Router Source (
source)Preview | Diff