-
Notifications
You must be signed in to change notification settings - Fork 140
[core-aam]: add Android to sections 1.1 and 1.2. #2680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cyns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Excited to see Android getting added!
|
Thanks, Cynthia! (great to see your name). I suspect the CI failure[1] is happening because the workflow is configured to fetch the branch name directly from origin (the main repo), but my branch exists on a fork. Some AI-suggested fixes[2] to this issue. I haven't spent time looking at this but can given appropriate perms. Probably simpler if someone with write access can do it :).
|
spectranaut
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks David!
On line 75, there is as "Authors" array which is used to create the "Platform Mapping Maintainers" list. I think, @dtsengchromium, we should add you for android, if so can you update the list:
{
name: "David Tseng",
company: "Google LLC",
note: "AccessibilityNodeInfo", // Or android.view.accessibilty or whatever the name of this API is
w3cid: ???, // TODO: get from Daniel
},
Also thanks for looking into the bot failure, but that is only relevant for changes to the ARIA spec specifically, so we can ignore it for this PR.
| <li><cite>User Interface Automation</cite> [[UI-AUTOMATION]]</li> | ||
| <li><cite>ATK - Accessibility Toolkit</cite> [[ATK]] and <cite>Assistive Technology Service Provider Interface</cite> [[AT-SPI]], referred to hereafter as "ATK/AT-SPI"</li> | ||
| <li><cite>macOS Accessibility Protocol</cite> [[AXAPI]]</li> | ||
| <li><cite>Android</cite> [[AccessibilityNodeInfo]]</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link doesn't work, it should bring us to an entry in the references section: https://w3c.github.io/core-aam/#references
However, I looked around a bit and I don't see how to do this. Also I noticed that there is a strange split between normative and informative references... which I suppose I'll make an issue about: w3c/core-aam#255
Also I wonder about the name, "AccessibilityNodeInfo", I think from looking at the documents that maybe it should be the umbrella android.view.accessibility
... because might we want to reference AccessibilityEvents as well?
Hi David, was great to see your name too! |
| name: "David Tseng", | ||
| company: "Google LLC", | ||
| mailto: "[email protected]", | ||
| note: "AccessibilityNodeInfo", // Or android.view.accessibilty or whatever the name of this API is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dtsengchromium could you please update this accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Daniel, the idea was to update the "Platform Mapping Maintainers" list, not the editors list -- the list that is called "authors" shows up in the "Platform Mapping Maintainers" list in the rendered specification. I'm not asking David to be an editor, just a platform mapping maintainer :)
No description provided.