Fix typos and minor editorial changes #10
Conversation
I read through the full document and, while reading, I hit some spelling errors or editorial issues. I have put them into this PR, I hope it will be helpful. I had some more issues with the technical content, but I would leave them for the time when the document is ready for a more public review. I am happy to re-review the document at the time, just ping me...
You seem to fail CI.. |
To be honest, I have no idea how that character appeared in the output. Anyway... I have just removed it.
simoneonofri
left a comment
simoneonofri
left a comment
There was a problem hiding this comment.
Thank you @iherman. Regarding the layers, maybe we can refer the Threat Stack differentiating the:
- Cryptographic primitives
- Mathematical foundations
SHA: cc56fe8 Reason: push, by verocri Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I read through the full document and, while reading, I hit some spelling errors or editorial issues. I propose some changes in this PR, I hope it will be helpful.
I had some more issues with the technical content, but I would leave them for the time when the document is ready for a more public review. I am happy to re-review the document at the time, just ping me...
A general issue: as an outsider, I would welcome, for each major section, a very short technical/mathematical summary of the underlying approach or approaches are, which would also shed some lights on the interrelationships of the sections. An example: I presume (but that is only a guess) that a MAC means combining the original message with the secret key (is it simply a concatenation?) and hash the result. If so, adding this information at the start of the section would be greatly helpful for the intended audience, imho.
Preview | Diff