fix: surface exit errors in the annotations #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidvishnoi
reviewed
Oct 6, 2025
| console.log(message); | ||
| } else { | ||
| console.log(message); | ||
| console.error(message); |
Member
There was a problem hiding this comment.
I guess we can remove the console.error?
Member
Author
There was a problem hiding this comment.
I couldn't find if core.error would still display the error in the logs themselves so I kept it.
sidvishnoi
changed the title
sidvishnoi
approved these changes
Oct 6, 2025
Contributor
|
Thanks @deniak and @sidvishnoi for looking into this. This is going to be a great time saver! |
Member
|
Hi, I'll merge and release this once I figure out #213. Without it, I'll have to revert some commits to get this PR in. I hope it's ok to have status quo for a few more days. |
Member
Author
|
Thanks @sidvishnoi. No rush, please deploy at your convenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error occurs, people are required to dig into the logs to find what went wrong, e.g. https://github.com/w3c/aria/actions/runs/18193307801
@daniel-montalvo suggested to use the annotations to surface the errors so we don't have to check logs.
That PR makes use of the actions toolkit to add the annotations when there's an error.