Skip to content
This repository was archived by the owner on Nov 7, 2024. It is now read-only.

Conversation

@jyasskin
Copy link
Member

@jyasskin jyasskin commented Jun 4, 2020

Depends on #30, since that changes the structure of the header cells.

It's hard to be sure that the checks and x's keep matching their column headers as the threat-model tables change, since they're far apart in the source, so this script emits console.errors when the local declaration of the goal doesn't match the reader-visible column header.

@tabatkins, FYI in case you see an easy way to surface these errors more visibly or, even better, during the Bikeshed build.


Preview | Diff

@tabatkins
Copy link

Hmm, so a general capability to explicitly tie cells to particular columns, to ensure order doesn't get messed up? Theoretically doable, yeah.

Copy link

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it contains the change from #30 as well, which makes it hard to review.

@jyasskin jyasskin force-pushed the check-tm-goal-order branch from 249b744 to f509cf5 Compare August 6, 2020 18:16
@jyasskin
Copy link
Member Author

jyasskin commented Aug 6, 2020

Now that #30 is merged, this is back to a single commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants