Skip to content

Conversation

@vivekgohel2004
Copy link

@vivekgohel2004 vivekgohel2004 commented Aug 28, 2025

Fix: update Text-Mate Theme entry (sublime_text version)

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is ...

There are no packages like it in Package Control.

My package is similar to ... However it should still be added because ...

Fix: update Text-Mate Theme entry (sublime_text version)
@vivekgohel2004 vivekgohel2004 changed the title Update t.json Add Text-Mate Theme to Package Control Aug 28, 2025
@vivekgohel2004
Copy link
Author

This PR adds my new theme "Text-Mate Theme".
Repo: https://github.com/vivekgohel2004/Text-Mate-Theme

Comment on lines +3924 to +3927
"name": "Text-Mate Theme",
"details": "https://github.com/vivekgohel2004/Text-Mate-Theme",
"author": "vivekgohel2004",
"labels": ["theme"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Text-Mate Theme",
"details": "https://github.com/vivekgohel2004/Text-Mate-Theme",
"author": "vivekgohel2004",
"labels": ["theme"],
"name": "Text-Mate Color Scheme",
"details": "https://github.com/vivekgohel2004/Text-Mate-Theme",
"labels": ["color scheme"],

As the file extension indicates, in Sublime Text parlance your package is not a "theme" (which is for UI elements only) but a "color scheme" (syntax highlighting).

You don't need to specify the author if it's your GitHub username.

Finally, Text-Mate is a bit of an unfortunate name because TextMate is an editor that ST (and VS Code) borrows a lot of config file formats from. Like the tmTheme file format ("Text Mate Theme")... using the words "Text Mate" in your package name without it having a relation to the TextMate editor is going to be really confusing for a lot of people 😅

@braver braver added the feedback provided The changes and package have been seen by a reviewer label Sep 17, 2025
@braver
Copy link
Collaborator

braver commented Sep 17, 2025

Please put your package in alphabetical order in the file (that's what CI complains about).

@braver
Copy link
Collaborator

braver commented Oct 15, 2025

👋🏻

@braver braver added the stale The author has not responded for at least 2 weeks label Oct 15, 2025
@braver braver closed this Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer stale The author has not responded for at least 2 weeks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants