Skip to content

Conversation

@dtoader
Copy link

@dtoader dtoader commented Oct 20, 2025

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is credited to Tito Bouzout.
It is released under the GNU General Public License
I've gotten permission to maintain it.

There are no packages like it in Package Control.
Text Selection is saved to new file using shortcut key.

Usage

  1. Select some text..
  2. Main menubar -> Selection -> Copy To New Files
  3. CTRL/CMD+P Selections: Copy To New Files

My package is similar to ... However it should still be added because ...

@kaste
Copy link
Contributor

kaste commented Oct 24, 2025

Hi! 👋 If that is a takeover you should actually point us to the original package. Likely we would just update the details URL or so. It should also be clear that you forked it from Tito. GitHub would tell us in their UI, "forked from ...". Tito might also mark it archived. Is there an issue where he says that you can have it? Changes to channel.json are not allowed and not necessary either. Look how the other packages are registered. "tags: true" is the option you likely want.

channel.json Outdated
"https://raw.githubusercontent.com/damccull/sublimetext-SolarizedToggle/master/packages.json",
"https://raw.githubusercontent.com/danielmagnussons/orgmode/master/packages.json",
"https://raw.githubusercontent.com/danielobrien/sublime-DLX-syntax/master/packages.json",
"https://raw.githubusercontent.com/dtoader/SelectionsToFiles/master/packages.json",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"https://raw.githubusercontent.com/dtoader/SelectionsToFiles/master/packages.json",

As already mentioned, this is not needed.

@braver
Copy link
Collaborator

braver commented Oct 25, 2025

It looks like Tito never published it as a package but just dropped the code on the forum. Most of his packages are retracted and repos are gone by. I can't find anything related in the channel. So it's fine to publish this way as far as I can tell. For completeness sake you could set SelectionsToFiles in previous_names though, that would be nice.

However, some changes are needed on the repository:

  • packages.json has to be removed, your "metadata" is here in this repo and everything else will be handled by the crawler
  • I'm a little bit concerned about a potentially decade-plus old script from Tito aimed at ST2 and 3 (4 has been out for ages)... I doubt it's still necessary given the latest state of the API. You're just inserting text into a new view, so perhaps use a TextCommand and simply insert.

@braver braver added the feedback provided The changes and package have been seen by a reviewer label Oct 25, 2025
@dtoader
Copy link
Author

dtoader commented Nov 5, 2025

Hi! 👋 If that is a takeover you should actually point us to the original package. Likely we would just update the details URL or so. It should also be clear that you forked it from Tito. GitHub would tell us in their UI, "forked from ...". Tito might also mark it archived. Is there an issue where he says that you can have it? Changes to channel.json are not allowed and not necessary either. Look how the other packages are registered. "tags: true" is the option you likely want.

Hi, the original package is no longer around. The original github repo was https://github.com/titoBouzout/SelectionsToFiles
See web archive.

I could not fork the original author's (Tito Bouzout [email protected]) SelectionsToFiles repo as it is no longer hosted on GitHub.
I happened to have the SelectionsToFiles package source files because I happened to download them to my workstation (and use them in my ST instance) back when they were available. See waybackarchive for the time inteval when SelectionsToFiles was hosted on github.
I emailed Tito Bouzout [email protected] and asked for permission to take over the SelectionsToFiles repo. Did not receive a reply.
The license is GNU General Public License.

@kaste
Copy link
Contributor

kaste commented Nov 5, 2025

I'm fooled also because Github's search isn't working: https://github.com/search?q=repo%3Awbond%2Fpackage_control_channel+SelectionsToFiles&type=commits <-- doesn't show when the package got removed. But git does locally

  [a]ll: true  -S'SelectionsToFiles'

...                               
| ● | | | | | | | | | | | | | | | 6940c5e5 Remove some packages                     ​ Mar 17 2016, Tito Bouzout
.. ● 5abb8504 add vraySublime                                                       ​ Jul 1 2015, unknown
| ● | | | | | | | | | | | | | | | | | | 00fd8a55 Upgraded to schema_version 3.0.0.. ​ Dec 10 2014, wbond
.. ● 44996366 SelectionsToFiles Attempt 1 :P                                        ​ May 9 2014, Tito

and then 6940c5e points to #5335

Do not set previous_names as you re-use the same name!

The code is out-dated and wouldn't pass for a new package. Can you actually -- in the sense of: are you capable of doing it -- just make it a TextCommand and drop the Edit abstraction?

…suffixed with the name string "SelectionsToFiles"

- Did not set "previous_names" as I'm using the same name as Tito Bouzout who was the original author, even this is a complete rewrite but with the same functionality
- Set tags to true
- Removed "https://raw.githubusercontent.com/dtoader/SelectionsToFiles/master/packages.json" from channel.json
@dtoader
Copy link
Author

dtoader commented Nov 6, 2025

I'm fooled also because Github's search isn't working: https://github.com/search?q=repo%3Awbond%2Fpackage_control_channel+SelectionsToFiles&type=commits <-- doesn't show when the package got removed. But git does locally

  [a]ll: true  -S'SelectionsToFiles'

...                               
| ● | | | | | | | | | | | | | | | 6940c5e5 Remove some packages                     ​ Mar 17 2016, Tito Bouzout
.. ● 5abb8504 add vraySublime                                                       ​ Jul 1 2015, unknown
| ● | | | | | | | | | | | | | | | | | | 00fd8a55 Upgraded to schema_version 3.0.0.. ​ Dec 10 2014, wbond
.. ● 44996366 SelectionsToFiles Attempt 1 :P                                        ​ May 9 2014, Tito

and then 6940c5e points to #5335

Do not set previous_names as you re-use the same name!

The code is out-dated and wouldn't pass for a new package. Can you actually -- in the sense of: are you capable of doing it -- just make it a TextCommand and drop the Edit abstraction?

I am capable of refactoring the SelectionsToFiles codebase to use TextCommand insert function.
Please see my latest commits (as of 11/5/2025 PST) to
https://github.com/dtoader/SelectionsToFiles
https://github.com/dtoader/package_control_channel/tree/AddSelectionsToFiles

@dtoader
Copy link
Author

dtoader commented Nov 6, 2025

I'm used to working off of JIRA issue numbers, creating an issue and having that flow into the bitbucket space. Any code change commit log message is prefixed with an issue string. Any way to do this in github?
I've made the requested changes and committed (with a nice descriptive log message) to the main branch of
https://github.com/dtoader/SelectionsToFiles
I've also made changes to the AddSelectionsToFiles branch of my package_control_channel fork
https://github.com/dtoader/package_control_channel/tree/AddSelectionsToFiles
Do I need to attempt to merge
https://github.com/dtoader/package_control_channel/tree/AddSelectionsToFiles
back into the main repo?
I'm assuming after making the requested changes, this package will get approved, merged and I'll be able to use the ST Package Control instead of local files.

@braver
Copy link
Collaborator

braver commented Nov 6, 2025

Any code change commit log message is prefixed with an issue string. Any way to do this in github?

You typically put the issue number in the commit message, e.g. #1234 fix problem.

Do I need to attempt to merge

No, any changes there appear in this PR, and by completing the PR and merging it here you'll be able to install the package via Package Control.

@braver
Copy link
Collaborator

braver commented Nov 6, 2025

Is the InsertTextCommand still in use for your package? It's not really exposed to end users.

@kaste
Copy link
Contributor

kaste commented Nov 6, 2025

It is used https://github.com/dtoader/SelectionsToFiles/blob/8be520ff3478561deedf5b9fadc4dff1fdc357b8/selections_copy_to_new_files.py#L98-L99

However I would recommend

-class SelectionsCopyToNewFilesCommand(sublime_plugin.WindowCommand):
+class SelectionsCopyToNewFilesCommand(sublime_plugin.TextCommand):

then you just flip at the beginning of your run

view = self.view
window = view.window()
if not window:
	return 

This should actually be more reliable because window.active_view() will not always return the focused view.

@braver
Copy link
Collaborator

braver commented Nov 16, 2025

Don't forget to tag your latest version. Since you're bringing an existing package back, and put in the effort to rewrite it already, I'm inclined to go ahead and ship it. But the latest tag still points at an old version.

@braver braver added the mergeable The channel changes are good but some action from the author is still needed label Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer mergeable The channel changes are good but some action from the author is still needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants