-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Added changes to add SelectionsToFiles Sublime Text package. #9228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi! 👋 If that is a takeover you should actually point us to the original package. Likely we would just update the details URL or so. It should also be clear that you forked it from Tito. GitHub would tell us in their UI, "forked from ...". Tito might also mark it archived. Is there an issue where he says that you can have it? Changes to channel.json are not allowed and not necessary either. Look how the other packages are registered. "tags: true" is the option you likely want. |
channel.json
Outdated
| "https://raw.githubusercontent.com/damccull/sublimetext-SolarizedToggle/master/packages.json", | ||
| "https://raw.githubusercontent.com/danielmagnussons/orgmode/master/packages.json", | ||
| "https://raw.githubusercontent.com/danielobrien/sublime-DLX-syntax/master/packages.json", | ||
| "https://raw.githubusercontent.com/dtoader/SelectionsToFiles/master/packages.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "https://raw.githubusercontent.com/dtoader/SelectionsToFiles/master/packages.json", |
As already mentioned, this is not needed.
|
It looks like Tito never published it as a package but just dropped the code on the forum. Most of his packages are retracted and repos are gone by. I can't find anything related in the channel. So it's fine to publish this way as far as I can tell. For completeness sake you could set SelectionsToFiles in However, some changes are needed on the repository:
|
Hi, the original package is no longer around. The original github repo was https://github.com/titoBouzout/SelectionsToFiles I could not fork the original author's (Tito Bouzout [email protected]) SelectionsToFiles repo as it is no longer hosted on GitHub. |
|
I'm fooled also because Github's search isn't working: https://github.com/search?q=repo%3Awbond%2Fpackage_control_channel+SelectionsToFiles&type=commits <-- doesn't show when the package got removed. But git does locally and then 6940c5e points to #5335 Do not set previous_names as you re-use the same name! The code is out-dated and wouldn't pass for a new package. Can you actually -- in the sense of: are you capable of doing it -- just make it a TextCommand and drop the Edit abstraction? |
…suffixed with the name string "SelectionsToFiles" - Did not set "previous_names" as I'm using the same name as Tito Bouzout who was the original author, even this is a complete rewrite but with the same functionality - Set tags to true - Removed "https://raw.githubusercontent.com/dtoader/SelectionsToFiles/master/packages.json" from channel.json
I am capable of refactoring the SelectionsToFiles codebase to use TextCommand insert function. |
|
I'm used to working off of JIRA issue numbers, creating an issue and having that flow into the bitbucket space. Any code change commit log message is prefixed with an issue string. Any way to do this in github? |
You typically put the issue number in the commit message, e.g.
No, any changes there appear in this PR, and by completing the PR and merging it here you'll be able to install the package via Package Control. |
|
Is the InsertTextCommand still in use for your package? It's not really exposed to end users. |
|
However I would recommend -class SelectionsCopyToNewFilesCommand(sublime_plugin.WindowCommand):
+class SelectionsCopyToNewFilesCommand(sublime_plugin.TextCommand):then you just flip at the beginning of your This should actually be more reliable because |
|
Don't forget to tag your latest version. Since you're bringing an existing package back, and put in the effort to rewrite it already, I'm inclined to go ahead and ship it. But the latest tag still points at an old version. |
My package is credited to Tito Bouzout.
It is released under the GNU General Public License
I've gotten permission to maintain it.
There are no packages like it in Package Control.
Text Selection is saved to new file using shortcut key.
Usage
My package is similar to ... However it should still be added because ...