Skip to content

Conversation

@chenjiahan
Copy link
Member

Summary

  • ensure dev/preview browser opening falls back to the base URL when no routes are provided

Testing

  • not run (not requested)

Codex Task

@netlify
Copy link

netlify bot commented Nov 23, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit ce1a4a6
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/6922519bd6d70f00084419d0
😎 Deploy Preview https://deploy-preview-6630--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 68 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot finished reviewing on behalf of chenjiahan November 23, 2025 00:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the browser opening functionality where the dev/preview server would not automatically open a browser when no routes are available. The fix adds a fallback to open the base URL in this scenario.

  • Added an else clause to handle empty routes array by falling back to base URL

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit 7650f7d into main Nov 23, 2025
18 checks passed
@chenjiahan chenjiahan deleted the codex/fix-bug-in-packages/core/src-directory branch November 23, 2025 05:00
@chenjiahan chenjiahan mentioned this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants