FSA: Reject moves with empty names #35850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 9, 2022
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3877252
branch
2 times, most recently
from
5567f09 to
b8c24dc
Compare
move("") rejects with a TypeError, while move(dir, "") succeeds
(by ignoring the second arg). Make this consistent by always rejecting
if there's an invalid name, as specified in
https://wicg.github.io/file-system-access/#valid-file-name
See whatwg/fs#10 (comment)
Bug: 1327741
Change-Id: Ifd8457df05aad7f75007ff5eece6237a09098a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3877252
Reviewed-by: Ayu Ishii <[email protected]>
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1059125}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3877252
branch
from
b8c24dc to
27c816e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move("") rejects with a TypeError, while move(dir, "") succeeds
(by ignoring the second arg). Make this consistent by always rejecting
if there's an invalid name, as specified in
https://wicg.github.io/file-system-access/#valid-file-name
See whatwg/fs#10 (comment)
Bug: 1327741
Change-Id: Ifd8457df05aad7f75007ff5eece6237a09098a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3877252
Reviewed-by: Ayu Ishii <[email protected]>
Commit-Queue: Austin Sullivan <[email protected]>
Reviewed-by: Emily Stark <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1059125}