Skip to content

make regex case insensitive #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sarchila wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make regex case insensitive #2

sarchila wants to merge 1 commit into from

Conversation

@sarchila
Copy link

@sarchila sarchila commented Aug 20, 2015

Not sure if this below is the intended behavior, but I've been running into issues with the case-sensitivity of the regex.

> var urlregexp = require('urlregexp')

> !!('google.com'.match(urlregexp)) // true
> !!('www.google.com'.match(urlregexp)) // true

> !!('Google.Com'.match(urlregexp)) // false
> !!('WWW.GOOGLE.COM'.match(urlregexp)) // false

This is a quick change that makes these all return true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sarchila