-
-
Notifications
You must be signed in to change notification settings - Fork 643
refactor!: remove init, loader, & plugin commands
#4297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Let's fix tests |
Member
Author
|
Yes, working on it. |
Member
Author
|
@alexander-akait Done. Should we also drop support for webpack-dev-server v4? |
anshumanv
approved these changes
Oct 22, 2024
Member
anshumanv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alexander-akait
approved these changes
Oct 22, 2024
snitin315
added a commit
that referenced
this pull request
Dec 17, 2024
alexander-akait
pushed a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Removed tests
If relevant, did you update the documentation?
yes
Summary
Remove
init,loader, andplugincommands in favor ofcreate-webpack-apppackage.Does this PR introduce a breaking change?
yes.
Other information
No