Skip to content

interceptor: simplify NACK generator close_rx error handling #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2025
+6 −8
Merged

interceptor: simplify NACK generator close_rx error handling #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions interceptor/src/nack/generator/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,12 @@ impl Generator {
internal: Arc<GeneratorInternal>,
) -> Result<()> {
let mut ticker = tokio::time::interval(internal.interval);
let mut close_rx = {
let mut close_rx = internal.close_rx.lock().await;
if let Some(close) = close_rx.take() {
close
} else {
return Err(Error::ErrInvalidCloseRx);
}
};
let mut close_rx = internal
.close_rx
.lock()
.await
.take()
.ok_or(Error::ErrInvalidCloseRx)?;

let sender_ssrc = rand::random::<u32>();
loop {
Expand Down
Loading