Skip to content

Conversation

@dschrempf
Copy link
Collaborator

Warn user in such cases.

Based on #1314 which should be merged first.

Travis and I agreed that trace messages should start with captial letters.

@dschrempf dschrempf marked this pull request as ready for review November 21, 2025 08:47
@dschrempf dschrempf self-assigned this Nov 24, 2025
@dschrempf dschrempf linked an issue Nov 26, 2025 that may be closed by this pull request
@@ -0,0 +1,7 @@
struct Omitted {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add another level here.

@dschrempf
Copy link
Collaborator Author

Test 1: Prescriptive binding with "omit foo", but we use foo (directly or
transitively). Check for correct/expected message.

Test 2: External binding specification with "omit foo".

  • Header 1: Does define foo and matches against external binding specification.
  • Header 2a: Does not use foo -> No messages at all.
  • Header 2a: Uses foo -> We generate bindings for the declaration foo that
    was omitted by an external binding specification. At the moment don't issue a
    warning but create a ticket: We could emit a warning in this case.

@dschrempf dschrempf force-pushed the dom/1155/duplicate-declarations branch from 82f67c3 to 2910847 Compare November 26, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deal with omitted (dependencies) in selection

2 participants