feat: added a way to upgrade wezterm-nightly #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a flags added livecheck which is used to determine whether an upgrade is executed or not. this livecheck uses the last-modified http header which is set to the date/time the file was uploaded to see if there is a new version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that you had to use
brew upgrade --cask wezterm-nightly --no-quarantine --greedy-latestto upgrade wezterm-nightly was annoying me so I started looking for a solution.Seeing that I'm not the only one annoyed by this (see #8 ) I've created this pull request which fixes the need for additional flags.
Apparently brew formulas use a livecheck to check whether an upgrade is done or not.
I've noticed that github sets the last-modified header to the date and time the file was uploaded and brew has a livecheck which is able to access http headers.
I'm using the date and time to construct a pseudo version which is just
<year><month><day><hour><minute><second>without the < >.Yesterday I've setup my own homebrew repo to test if this would work and it does.
I've been able to upgrade nightly like any other cask.
I'll open a pull request on the official homebrew-cask repo as well although I'm not sure if it'll get accepted because the livecheck I've used states:
This is the reason I'm opening the pull request here first.
That being said I've seen other casks in the official repo which also use this livecheck strategy.