Fix/end date picker validation #870
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this PR fixes the end date picker issue. Kindly review when you have time. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
-Fix end date picker so that the initial date is always after the start date and never before it.
-Prevents assertion errors in the date picker dialog when the end date is before or equal to the start date.
-Allows users to select end dates up to 10 years in the future.
Related Issue(s)
If applicable, please link to any related issues (
Closes #123,Closes wger-project/other-repo#123,See also #123, etc.)Please check that the PR fulfills these requirements
(run
dart format .)///).