Fix login bug causing incorrect credential handling #2087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi! what do you mean that there is no feedback? If the password doesn't match there's an info box 
Also, did you commit the wrong file? |
|
@abbadinikhilreddy55 sorry there seems to be some misunderstanding. What exactly did you change? The PR only adds a new file "edit file" that seems to be a copy of the urls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I changed
Fixed an issue where the login flow did not properly handle incorrect user credentials, resulting in unexpected errors or no error messages shown.
Why I changed it
Users were unable to see appropriate error feedback when entering wrong login details, which caused confusion and prevented proper authentication.
How I tested it