Skip to content

Conversation

@DidiNDexter
Copy link
Contributor

Standardized app-store badge heights for consistent layout

Proposed Changes

Related Issue(s)

If applicable, please link to any related issues (Closes #123,
Closes wger-project/other-repo#123, See also #123, etc.)

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Code has been formatted to avoid unnecessary diffs (ruff format && isort .)

Other questions

  • Do users need to run some commands in their local instances due to this PR
    (e.g. database migration, deployment changes)?

Standardized app-store badge heights for consistent layout
@DidiNDexter
Copy link
Contributor Author

Hi @maintainer, I’ve completed the requested badge alignment updates to the best of my ability

@rolandgeider
Copy link
Member

The apple one is still a bit smaller (I have no idea where that size comes from):
https://github.com/DidiNDexter/wger/tree/DidiNDexter-patch-2
Bildschirmfoto 2025-10-29 um 13 10 47

Also, this blue line is from the space between the end of the image tag and the </a>. Just put them on the same line, even if it looks a bit ugly
Bildschirmfoto 2025-10-29 um 13 09 21

@DidiNDexter
Copy link
Contributor Author

I did my best, increased the height changed so many things and it didnt get bigger

Moved closing </a> tags next to <img> tags for cleaner formatting
@DidiNDexter
Copy link
Contributor Author

Pls check to see if it was updated

@rolandgeider rolandgeider linked an issue Oct 29, 2025 that may be closed by this pull request
@rolandgeider rolandgeider changed the title Update README.md Make app-store badges uniform in height Oct 29, 2025
@rolandgeider rolandgeider merged commit c6710a2 into wger-project:master Oct 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make app-store badges uniform in height for visual consistency

2 participants