Improve option element nearest ancestor select algorithm #11789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the "option element nearest ancestor select" algorithm to incorporate cases where the option element is nested inside of option, hr, optgroup, or datalist elements to match the option list algorithm. Fixes whatwg#11788
annevk
reviewed
Oct 15, 2025
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
This looks good. I guess this is sufficient if we're storing a pointer on option. I hope we can continue to avoid requiring that particular implementation choice however.
annevk
approved these changes
Oct 17, 2025
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Looks good, but CI is unhappy.
annevk
reviewed
Oct 17, 2025
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the "option element nearest ancestor select" algorithm to incorporate cases where the option element is nested inside of option, hr, optgroup, or datalist elements to match the option list algorithm.
Fixes #11788
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )