Skip to content

Conversation

@hymccord
Copy link

@hymccord hymccord commented Sep 7, 2025

Fixes: #68

Copilot AI review requested due to automatic review settings September 7, 2025 18:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes tab identification logic in the _onLoad event handler by replacing incorrect array indexing with proper tab lookup by ID. The change ensures that when a child tab sends a LOADED message with its UUID, the parent correctly identifies and updates the specific tab rather than assuming it's the last tab in the array.

  • Replaces last-tab assumption with ID-based tab lookup using arrayUtils.searchByKeyName
  • Adds null check to prevent errors when the specified tab ID is not found
  • Maintains existing tab property updates only when the target tab is successfully located

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hymccord hymccord force-pushed the bug/fix-onLoad-communication branch from 4eb2495 to 36db135 Compare September 7, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handshake issue with multiple children

1 participant