-
Notifications
You must be signed in to change notification settings - Fork 510
autolinking improvement for android #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
With this config file cli will be able to find the sourceDir for android. This will fix "Invariant Violation requireNativeComponent 'InteractableView' was not found in UiManager" error for RN >= 0.60.
dakenf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine.
lelukas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine.
RodPin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected !
toshe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-linking works with RN 0.60.
|
I don't understand this. Without this pull request auto-linking does not work with 0.60. |
|
Any update on this merge request? Android linking is still broken. |
With this config file cli will be able to find the sourceDir for android. This will fix
Invariant Violation requireNativeComponent 'InteractableView' was not found in UiManager.error for RN >= 0.60.Autolinking works well for iOS if you have the
Interactable.podspecfile. But if you add the library fromnpm(v1.0.0) for some reason it won't be added. So make sure you havepodspecfile in the root of the library before runningpod install