Fix CERT_REQUIRED verify mode not setting SSL_VERIFY_FAIL_IF_NO_PEER_CERT and therefore failing to verify the client cert. #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CERT and therefore failing to verify the client cert. Thanks to Matan Radomski for the report.
Contributor
Author
|
PRB script needs an update: https://github.com/wolfSSL/testing/pull/906 |
Contributor
Author
|
Retest this please |
Contributor
|
Changes look good. Can you add some testing that would have failed before this fix? |
…IRED is set and the client doesn't send a cert.
lealem47
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CERT_REQUIRED is behaving as CERT_OPTIONAL is described ie. the client cert is validated but the connection does not close if it is found to be invalid.
Thanks to Matan Radomski for the report.