Skip to content

Conversation

@lucamug
Copy link
Contributor

@lucamug lucamug commented Jul 7, 2025

… to avoid a corrupted cache issue with the Elm compiler.

See Issue #205.

@miniBill
Copy link
Collaborator

miniBill commented Jul 7, 2025

I really don't love this. It fixes the case where it needs fixing, but also makes the names bad in cases where it doesn't need fixing.

I wonder if we could do something similar to enums where we pick the name the user chooses if it's defined in a schema?

And possibly error or hash otherwise.

But I'd really love to not hash if we have like, two short names

@miniBill
Copy link
Collaborator

miniBill commented Jul 7, 2025

<         , workflow_id : GithubV3RestApi.Types.Int_Or_String
---
>         , workflow_id : GithubV3RestApi.Types.OneOf40166559716753c6753

This is an example of what I'd like to avoid

@miniBill
Copy link
Collaborator

miniBill commented Jul 7, 2025

I think I'm open to "this PR, but only for names longer than X" where X is the maximum we can safely afford

@miniBill
Copy link
Collaborator

miniBill commented Jul 29, 2025

@lucamug I've added a commit that picks 200 as an arbitrary cutoff, do you know what the actual number should be?

Do you have an openapi spec that fails?

@miniBill
Copy link
Collaborator

@wolfadex I think this is ready to be merged [it produces an empty diff], I'm just unsure on the numerical limit

@miniBill
Copy link
Collaborator

The error is because this is a PR from a branch so it's not allowed to write the diff message, but looking at the logs the diff is now zero

@wolfadex ready to merge

@wolfadex wolfadex merged commit 8443ff7 into wolfadex:main Sep 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants