Skip to content

Don't use empty on compatibility code #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcfreak30 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't use empty on compatibility code #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcfbf7a
Merge pull request #1 from woocommerce/master
pcfreak30 Feb 22, 2020
2ac95cb
*Don't use empty check
pcfreak30 Mar 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions includes/class-wc-product-tables-backwards-compatibility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public static function get_from_product_table( $args ) {
$data = array();
}

if ( empty( $data[ $args['column'] ] ) ) {
if ( ! isset( $data[ $args['column'] ] ) ) {
$escaped_column = '`' . esc_sql( $args['column'] ) . '`';
$data[ $args['column'] ] = $wpdb->get_col(
$wpdb->prepare(
Expand Down Expand Up @@ -311,7 +311,7 @@ public static function get_from_relationship_table( $args ) {

$data = wp_cache_get( 'woocommerce_product_backwards_compatibility_' . $args['type'] . '_relationship_' . $args['product_id'], 'product' );

if ( empty( $data ) ) {
if ( false === $data ) {
$data = array(
array(
$wpdb->get_col( $wpdb->prepare( "SELECT DISTINCT object_id from {$wpdb->prefix}wc_product_relationships WHERE product_id = %d AND type = %s", $args['product_id'], $args['type'] ) ),
Expand Down