Skip to content

Cache should not be checked when fetching a product before updating it #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcfreak30 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cache should not be checked when fetching a product before updating it #179

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcfbf7a
Merge pull request #1 from woocommerce/master
pcfreak30 Feb 22, 2020
75a542d
*Refactor get_product_row_from_db to allow not checking cache before …
pcfreak30 Mar 16, 2020
e99f6bc
*Bypass cache when fetching product row to check if it needs to be added
pcfreak30 Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions includes/data-stores/class-wc-product-data-store-custom-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ protected function update_product_data( &$product ) {
);
$changes = $product->get_changes();
$insert = false;
$row = $this->get_product_row_from_db( $product->get_id() );
$row = $this->get_product_row_from_db( $product->get_id(), true );

if ( ! $row ) {
$insert = true;
Expand Down Expand Up @@ -230,15 +230,19 @@ protected function update_product_data( &$product ) {
/**
* Get product data row from the DB whilst utilising cache.
*
* @param int $product_id Product ID to grab from the database.
* @param int $product_id Product ID to grab from the database.
* @param bool $skip_cache Don't check object cache and fetch directly from database.
*
* @return array
*/
protected function get_product_row_from_db( $product_id ) {
protected function get_product_row_from_db( $product_id, $skip_cache = false ) {
global $wpdb;

$data = wp_cache_get( 'woocommerce_product_' . $product_id, 'product' );
if ( ! $skip_cache ) {
$data = wp_cache_get( 'woocommerce_product_' . $product_id, 'product' );
}

if ( false === $data ) {
if ( $skip_cache || false === $data ) {
$data = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$wpdb->prefix}wc_products WHERE product_id = %d;", $product_id ) ); // WPCS: db call ok.

wp_cache_set( 'woocommerce_product_' . $product_id, $data, 'product' );
Expand Down