Fix problem with deploy #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to keeping track of blockly workspaces. Modified editor to call workspaces.addWorkspace and workspaces.removeWorkspace Modified existing code that use headless blockly workspaces to call workspaces.createHeadlessWorkspace and workspaces.destroyHeadlessWorkspace.
…duleTypeForWorkspace instead of trying to get the corresponding editor. If the block is in a headless workspace, there is no corresponding editor.
…face into pr_issue_287_deploy_bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added workspaces.ts, which provides functions related to blockly workspaces.
Changed code in blocks that called Editor.getEditorForBlocklyWorkspace. Instead, Editor is passed in to mrcOnLoad and mrcOnModuleCurrent, or workspaces.getModuleTypeForWorkspace is used.
Fixes #287