Skip to content

Minor CSS fix ups #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2025
Merged

Minor CSS fix ups #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions vscode-wpilib/resources/media/icons.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,11 @@
.codicon-chrome-minimize:before {
content: '\eaba';
}

.codicon-notebook:before {
content: '\ebaf';
}

.codicon-notebook-template:before {
content: '\ebbf';
}
23 changes: 4 additions & 19 deletions vscode-wpilib/resources/media/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,6 @@
}
}

.uninstall-button .vscode-select select {
height: 24px;
box-sizing: border-box;
line-height: 18px;
padding: 2px 4px;
border-radius: 2px;
}

.uninstall-button button[id*='version-action'],
.uninstall-button button[id*='uninstall-action'],
.uninstall-button button[id*='install-action'] {
Expand Down Expand Up @@ -166,17 +158,6 @@ button[id*='version-action'] {
width: 100%;
}

.project-select {
min-width: 250px;
background-color: var(--vscode-dropdown-background);
border: 1px solid var(--vscode-dropdown-border);
color: var(--vscode-dropdown-foreground);
padding: 6px 8px;
border-radius: 4px;
cursor: pointer;
width: 100%;
}

.project-actions {
display: flex;
justify-content: flex-end;
Expand Down Expand Up @@ -344,6 +325,10 @@ button[id*='version-action'] {
color: var(--vscode-descriptionForeground);
}

.card-icon i.codicon {
font-size: 48px;
}

.selection-card.selected .card-icon {
color: var(--vscode-button-background);
}
Expand Down
24 changes: 8 additions & 16 deletions vscode-wpilib/resources/webviews/projectcreator.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,24 +32,14 @@ <h2>Step 1: Select Project Type</h2>
<h3>Template</h3>
<p>Start with a basic robot program structure</p>
<div class="card-icon">
<svg viewBox="0 0 24 24" width="48" height="48">
<path
fill="currentColor"
d="M14,17H7V15H14M17,13H7V11H17M17,9H7V7H17M19,3H5C3.89,3 3,3.89 3,5V19A2,2 0 0,0 5,21H19A2,2 0 0,0 21,19V5C21,3.89 20.1,3 19,3Z"
/>
</svg>
<i class="codicon codicon-notebook-template"></i>
</div>
</div>
<div class="selection-card" data-value="Example">
<h3>Example</h3>
<p>Start with a complete example project</p>
<div class="card-icon">
<svg viewBox="0 0 24 24" width="48" height="48">
<path
fill="currentColor"
d="M8,16H16V18H8V16M8,12H16V14H8V12M14,2H6A2,2 0 0,0 4,4V20A2,2 0 0,0 6,22H18A2,2 0 0,0 20,20V8L14,2M18,20H6V4H13V9H18V20Z"
/>
</svg>
<i class="codicon codicon-notebook"></i>
</div>
</div>
</div>
Expand All @@ -70,17 +60,19 @@ <h2>Step 2: Select Language & Base</h2>

<div class="project-row">
<div class="project-label"><b>Language</b></div>
<div class="select-wrapper">
<select id="language-select" class="project-select" disabled>
<div class="select-wrapper vscode-select">
<i class="codicon codicon-chevron-right chevron-icon"></i>
<select id="language-select" disabled>
<option value="" selected disabled>Select a language</option>
</select>
</div>
</div>

<div class="project-row">
<div class="project-label"><b>Project Base</b></div>
<div class="select-wrapper">
<select id="base-select" class="project-select" disabled>
<div class="select-wrapper vscode-select">
<i class="codicon codicon-chevron-right chevron-icon"></i>
<select id="base-select" disabled>
<option value="" selected disabled>Select a project base</option>
</select>
</div>
Expand Down
5 changes: 4 additions & 1 deletion vscode-wpilib/src/webviews/webviewbase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ export abstract class WebViewBase {

this.html = this.html.replace(
'</head>',
`<link rel="stylesheet" href="replaceresource/resources/media/icons.css" />\r\n<link rel="stylesheet" href="replaceresource/resources/media/vscode-elements.css" />\r\n<link rel="stylesheet" href="replaceresource/resources/media/main.css" />\r\n</head>`
`<link rel="stylesheet" href="replaceresource/resources/media/icons.css" />
<link rel="stylesheet" href="replaceresource/resources/media/vscode-elements.css" />
<link rel="stylesheet" href="replaceresource/resources/media/main.css" /></head>
`
);

if (localeDomains) {
Expand Down