Ahmet/eng 8386 implement oauth 21 authorization and protected resource #2292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements header forwarding from MCP requests to GraphQL endpoint with
opt-in configuration for additional headers beyond Authorization.
Key changes:
- Authorization header is always forwarded (maintains backward compatibility)
- New `forward_headers` config with `enabled` (default: false) and `allow_list`
- Support for exact header matches and regex patterns (e.g., "X-.*")
- Case-insensitive header matching
- Context-based header storage and filtering
- Comprehensive unit tests for filtering logic
- Updated JSON schema with validation
Configuration example:
```yaml
mcp:
forward_headers:
enabled: true
allow_list:
- "X-Tenant-ID"
- "X-Trace-ID"
- "X-.*"
…e-router-in-the-mcp-server
Implement JWKS-based JWT token validation for MCP server with: MCPAuthorizationConfiguration for config management TokenValidator with HTTP middleware integration JSON schema validation support Reuses router's authentication infrastructure Authorization is opt-in (disabled by default) and supports multiple authorization servers with automatic key rotation.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Checklist