[internal] adds tests for internal files #184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Can you add |
ccoVeille
reviewed
Dec 1, 2025
colinjlacy
force-pushed
the
issue149_add-internal-tests
branch
from
f5c7eac to
f9ecb9f
Compare
ccoVeille
approved these changes
Dec 3, 2025
Contributor
ccoVeille
left a comment
ccoVeille
left a comment
There was a problem hiding this comment.
I didn't review all tests. But based in the fact you are not updating the code, but adding tests I feel like I can approve anyway.
ccoVeille
approved these changes
Dec 4, 2025
ingydotnet
force-pushed
the
issue149_add-internal-tests
branch
from
849f684 to
e968d03
Compare
ingydotnet
added a commit
that referenced
this pull request
Dec 5, 2025
Refactored from @colinjlacy's #184 Use super clean, simple, consistent and documented foo_test.yaml files for test data, and minimal foo_test.go files for the code running the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds unit tests in the integration
style to the internal/libyaml directory. it
focuses primarily on the majority use cases and
does not get too creative with edge-case yaml
examples, which can likely be filled in as issues
are opened and bugs are squashed. The majority of
these tests were written by Claude in cursor.
To test, simply run:
fixes #149 in part