Add MarshalerWithContext and UnmarshalerWithContext interfaces #186
+126
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Nov 27, 2025
Contributor
There was a problem hiding this comment.
I feel like this is PR is good, but we might need to find a better way to address the issue it tries to fix.
I'm not expecting you to work on a new implementation. I'm sure you can.
I'm not looking for it for now.
I feel like the discussion should continue in the issue you opened rather than here in the code
| // Decoder, unmarshals a node into a provided value. | ||
|
|
||
| type decoder struct { | ||
| ctx context.Context |
Contributor
There was a problem hiding this comment.
Having a context stored in a struct is an anti pattern.
For me, there is a problem here.
But it might be needed if we don't want a PR that breaks everything and methods signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.