add null check #389
Open
add null check #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for adding this null check is that sometimes, for eg. in case of building yuidoc for https://github.com/photonstorm/phaser, when you try to toggle from 'classes' panel to 'modules' panel, the following error is being thrown -: ```Uncaught TypeError: Cannot read property 'toLowerCase' of null```. For catching this error, I think adding a null check would be a good solution. Although I think, there might be some other reason which is leading to the error in the above case. Please check this. For your reference, version of my yuidoc is 0.9.0 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for adding this null check is that sometimes, for eg. in case of building yuidoc for https://github.com/photonstorm/phaser, when you try to toggle from 'classes' panel to 'modules' panel, the following error is being thrown -:
Uncaught TypeError: Cannot read property 'toLowerCase' of null.For catching this error, I think adding a null check would be a good solution. Although I think, there might be some other reason which is leading to the error in the above case. Please check this. For your reference, version of my yuidoc is 0.9.0 .