Skip to content

Use localID for eksID to remove some redundancy #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linki merged 1 commit into from
Sep 18, 2024
Merged

Use localID for eksID to remove some redundancy #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion provisioner/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,8 @@ func list(args ...interface{}) []interface{} {
}

func eksID(id string) string {
return strings.Replace(id, ":", "--", -1)
parts := strings.Split(id, ":")
return parts[len(parts)-1]
}

// accountID returns just the ID part of an account
Expand Down
2 changes: 1 addition & 1 deletion provisioner/template_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ func TestEKSID(t *testing.T) {
`{{ eksID "aws:000000:eu-north-1:kube-1" }}`,
"")
require.NoError(t, err)
require.EqualValues(t, "aws--000000--eu-north-1--kube-1", result)
require.EqualValues(t, "kube-1", result)
}

func TestParsePortRanges(t *testing.T) {
Expand Down