-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Refactor/remove unused deps and clones #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor/remove unused deps and clones #1169
Conversation
- kms-connector/utils: remove unused serial_test - fhevm-engine/stress-test-generator: remove 11 unused deps - fhevm-engine/tfhe-worker: remove 4 unused deps (actix-web, tonic-*) Detected by cargo-udeps
- Remove unnecessary .clone() and .to_owned() calls - Improves performance by avoiding unnecessary allocations Detected by clippy::redundant_clone
|
Hi, I am launching the workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting workflow execution to approve
|
Note that you need to resolve the conflicts to be able to run the github workflows. |
|
Hi, thanks for the review! @rudy-6-4 |
Resolved conflicts in: - coprocessor/fhevm-engine/gw-listener/src/aws_s3.rs - coprocessor/fhevm-engine/gw-listener/src/gw_listener.rs
Add clippy::redundant_clone warning to prevent future regressions as requested in code review.
|
I've enabled I've also resolved the merge conflicts with For finding all clone-related issues locally, I used: cargo clippy --all-targets -- -W clippy::redundant_clone -W clippy::clone_on_copy -W clippy::unnecessary_to_ownedAnd for unused dependencies: cargo +nightly udeps --all-targetsIf you'd like to add |
|
@rudy-6-4 |
Summary
This PR removes unused dependencies and eliminates redundant clone operations across the codebase, improving build times and runtime performance.
Changes
kms-connector:
serial_testfrom connector-utils (dev-dependency)fhevm-engine/stress-test-generator:
aws-sdk-s3,humantime,regex,scheduler,semver,serial_test,test-harness,testcontainers,tfhe-worker,tonic-build,zkproof-workerfhevm-engine/tfhe-worker:
actix-web,tonic-health,tonic-types,tonic-webRedundant Clones Removed (11 total)
fhevm-engine-common: 4 unnecessary.clone()callsscheduler: 3 unnecessary.clone()callsgw-listener: 3 unnecessary.to_owned()callskms-worker: 1 unnecessary.to_string()callTesting