Update calldata.rs #1174
Open
Update calldata.rs #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong / inconsistent ABI-encoding usage You mixed the instance method (call.abi_encode()) with an (unlikely) associated call (Type::abi_encode(&call)). With Alloy’s SolCall, abi_encode is an instance method. Fixed to use it consistently. Redundant Bytes::from(...) abi_encode() already returns alloy::primitives::Bytes. No need to re-wrap. Removed extra conversions. Tiny cleanups Inlined trivial extra_data where helpful; kept behavior identical.
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @0xLayer-3 on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong / inconsistent ABI-encoding usage
You mixed the instance method (call.abi_encode()) with an (unlikely) associated call (Type::abi_encode(&call)). With Alloy’s SolCall, abi_encode is an instance method. Fixed to use it consistently.
Redundant Bytes::from(...)
abi_encode() already returns alloy::primitives::Bytes. No need to re-wrap. Removed extra conversions.
Tiny cleanups
Inlined trivial extra_data where helpful; kept behavior identical.