Skip to content

Fix std::max compilation error on Windows #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

Fix std::max compilation error on Windows #656

merged 1 commit into from
Apr 18, 2025

Conversation

@cacharle
Copy link
Contributor

@cacharle cacharle commented Apr 17, 2025

Fixes #654

@cacharle
Copy link
Contributor Author

cacharle commented Apr 18, 2025

I might be blind but I do not see the Windows CI/CD compile errors

@gummif
Copy link
Member

gummif commented Apr 18, 2025

Yeah, it has not worked for a while. I think this is fine since it works on gcc and clang.

@gummif gummif merged commit 78f91ad into zeromq:master Apr 18, 2025
2 of 10 checks passed
@botantony botantony mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

std::max causes compilation error on Windows

2 participants

@cacharle @gummif