Skip to content

Conversation

@jeffective
Copy link
Contributor

@jeffective jeffective commented Nov 3, 2025

Does not fully close #24361 (this is only a first, simple change set)

Summary:

  • where the type of the operands allows, change expectEqual(x, y) to expect(x == y) for files in test/behavior/**
# without these changes (master branch)
$ git grep expectEqual test/behavior | wc -l
1018

# with these changes
$ git grep expectEqual test/behavior | wc -l
314

My editor was configured to re-order imports on save. Hope that isn't a huge issue.

Verification evidence:

  • the CI should pass, no new tests are introduced, only changes to existing tests

note: I had closed my previous PR to prevent unintended CI runs during rebase etc #24389

note to self: use this for testing if you have to rebase again:

zig build test-behavior -Dskip-release -Dskip-non-native -Dskip-llvm=true -Dskip-libc -Dskip-single-threaded --watch

@jeffective
Copy link
Contributor Author

jeffective commented Nov 3, 2025

Looks like windows CI failure is #22510 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Behavior tests should avoid expectEqual and friends

1 participant