Skip to content

feat: enhance DKIM verification with improved domain matching and error reporting #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: enhance DKIM verification with improved domain matching and error reporting #254

wants to merge 2 commits into from

Conversation

@shreyas-londhe
Copy link
Member

@shreyas-londhe shreyas-londhe commented Apr 15, 2025 •
edited by BornPsych
Loading

Description

This PR:

  • Added support for extracting the domain from the From header if not provided.
  • Implemented additional checks for DKIM results, including subdomain matching and a fallback for Google Apps domains.
  • Updated error messages to include available signing domains when a DKIM signature is not found.
  • Adjusted tests to reflect changes in error messages and ensure proper verification behavior.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@shreyas-londhe
feat: enhance DKIM verification with improved domain matching and err…
5fbbffd 
…or reporting

- Added support for extracting the domain from the From header if not provided.
- Implemented additional checks for DKIM results, including subdomain matching and a fallback for Google Apps domains.
- Updated error messages to include available signing domains when a DKIM signature is not found.
- Adjusted tests to reflect changes in error messages and ensure proper verification behavior.
@shreyas-londhe
chore: bump lib version
d1b3ce4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shreyas-londhe