fix: SHA hashing with Uint8Array support #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

hexcow wants to merge 1 commit into zkemail:main from hexcow:patch-2

hexcow commented Aug 29, 2025

Description

updated the script to correctly handle Uint8Array inputs.

replaced the crypto import and CryptoJS.createHash usage with Node.js standard createHash
shaHash now works correctly with Uint8Array
no other changes to the code

Type of Change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

I have discussed with the team prior to submitting this PR
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing unit tests pass locally with my changes


          fix: SHA hashing with Uint8Array support

8251bb3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet