Replaced commentjson with json5 to support block comments #374
Conversation
Signed-off-by: aadityasinha-dotcom <[email protected]>
Signed-off-by: aadityasinha-dotcom <[email protected]>
t1m0thyj
changed the title
t1m0thyj
left a comment
t1m0thyj
left a comment
There was a problem hiding this comment.
@aadityasinha-dotcom Thanks for your contribution!
Could you please add a unit test to validate that config files containing block comments can be loaded?
Also please replace the commentjson dependency in these places:
zowe-client-python-sdk/README.md
Line 51 in fd176ff
zowe-client-python-sdk/src/core/setup.py
Line 37 in fd176ff
t1m0thyj
left a comment
t1m0thyj
left a comment
There was a problem hiding this comment.
Sorry, meant to request changes - see comment above
Signed-off-by: aadityasinha-dotcom <[email protected]>
…ient-python-sdk into comment_json
t1m0thyj
left a comment
t1m0thyj
left a comment
There was a problem hiding this comment.
@aadityasinha-dotcom Thanks for updating references to the dependency 😁
Please add a unit test to validate that config files containing block comments can be loaded.
Co-authored-by: Timothy Johnson <[email protected]> Signed-off-by: Aaditya Sinha <[email protected]>
Signed-off-by: aadityasinha-dotcom <[email protected]>
Signed-off-by: aadityasinha-dotcom <[email protected]>
…ient-python-sdk into comment_json
|
|
||
| self.assertEqual(str(actual_info.exception), str(expected_info.exception)) | ||
|
|
||
| def test_validate_config_json_with_block_comments(self): |
There was a problem hiding this comment.
Hello, sorry for taking so much time 😓, I have added the unit test to load and validate config json with block comments
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
=======================================
Coverage 81.86% 81.86%
=======================================
Files 48 48
Lines 2768 2768
=======================================
Hits 2266 2266
Misses 502 502
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: aadityasinha-dotcom <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
…into comment_json Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]> Signed-off-by: Aaditya Sinha <[email protected]>
t1m0thyj
left a comment
t1m0thyj
left a comment
There was a problem hiding this comment.
LGTM, thanks @aadityasinha-dotcom!
4 participants
What It Does
Resolves #357
How to Test
Review Checklist
I certify that I have:
Additional Comments