Skip to content

Conversation

@poscat0x04
Copy link

Update versions of various dependencies. Notably electron from 32 to 34 since 34 improves wayland IME support.

Fixes:

Screenshots and screen captures:

Platforms this PR was tested on:

  • Windows
  • macOS
  • Linux (arch)
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Update versions of various dependencies. Notably electron from 32 to 34
since 34 improves wayland IME support.
@devurandom
Copy link

This is particularly important, since Electron 32 is EOL: https://www.electronjs.org/docs/latest/tutorial/electron-timelines
Note that Electron 35 is also released already: https://releases.electronjs.org/

@andersk
Copy link
Member

andersk commented Mar 13, 2025

Thanks, though I handle dependency upgrades as part of our normal release process (see previous release PRs), which is already in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants