docs: getPayout() throws if there's no payment for the keyword #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Jan 3, 2025
Member
turadg
left a comment
turadg
left a comment
There was a problem hiding this comment.
Doesn't hurt but seems to me like a detail we should leave to docs generated from source code
Deploying documentation with
|
| Latest commit: |
1b20193
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9adb1186.documentation-7tp.pages.dev |
| Branch Preview URL: | https://10738-getpayoutthrows.documentation-7tp.pages.dev |
|
Cloudflare deployment logs are available here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 8610 pointed out that
E(zoeSeat).getPayout('foo');returned undefined when the keyword was unknown, while the types claimed that it always returned a Payment.10738 changed Zoe to throw if the Payment didn't exist. This PR updates the documentation to mention that error.