Skip to content

Conversation

@jeremymeng
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings October 31, 2025 22:36
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Oct 31, 2025
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/storage-internal-avro

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates test assertions across multiple Azure Storage SDK test files from generic assert.ok() calls to more specific and semantically meaningful assertion methods from the test assertion library. The changes improve test clarity and maintainability by making assertions more explicit about their intent.

Key changes:

  • Replaced assert.ok() with specific assertions like assert.isDefined(), assert.isTrue(), assert.isFalse(), etc.
  • Updated equality checks from assert.ok(x === y) to assert.strictEqual(x, y)
  • Changed string inclusion checks from assert.ok(str.includes(substr)) to assert.include(str, substr)
  • Modernized comparison assertions to use assert.isAbove(), assert.isAtLeast(), etc.

Reviewed Changes

Copilot reviewed 70 out of 70 changed files in this pull request and generated 24 comments.

Show a summary per file
File Description
storage-queue/test/utils.spec.ts Updated assertions for URL and header sanitization tests
storage-queue/test/queueserviceclient.spec.ts Improved assertions for queue service operations
storage-queue/test/queueclientmessages.spec.ts Enhanced message operation test assertions
storage-queue/test/queueclient.spec.ts Refined queue client test assertions
storage-queue/test/node/*.spec.ts Updated Node.js-specific test assertions
storage-queue/test/aborter.spec.ts Improved aborter test assertions
storage-internal-avro/test/**/*.spec.ts Enhanced Avro reader test assertions
storage-file-share/test/**/*.spec.ts Comprehensive assertion updates for file share tests
storage-file-datalake/test/**/*.spec.ts Enhanced Data Lake test assertions

@jeremymeng jeremymeng force-pushed the test/storage-replace-assert-ok branch from 02e43ab to 956ab11 Compare October 31, 2025 23:17
@jeremymeng jeremymeng merged commit b91774a into Azure:main Nov 6, 2025
13 checks passed
@jeremymeng jeremymeng deleted the test/storage-replace-assert-ok branch November 6, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants