[test][storage] replace assert.ok with specific assertions

sdk/storage/storage-blob-changefeed/test/blobchangefeedclient.spec.ts

@@ -50,8 +50,8 @@ describe(
       let i = 0;
       for await (const event of changeFeedClient.listChanges()) {
         if (i++ === 0) {
-          assert.ok(event.eventType);
-          assert.ok(event.data.blobType);
+          assert.isDefined(event.eventType);
+          assert.isDefined(event.data.blobType);
         }
       }
     });
@@ -65,15 +65,15 @@ describe(
       const endRounded = new Date(Date.UTC(2020, 4, 8, 22, 0, 0));
       for await (const event of changeFeedClient.listChanges({ start, end })) {
         if (i++ === 0) {
-          assert.ok(event.eventType);
-          assert.ok(event.data.blobType);
-          assert.ok(event.eventTime >= startRounded);
+          assert.isDefined(event.eventType);
+          assert.isDefined(event.data.blobType);
+          assert.isTrue(event.eventTime >= startRounded);
         }
         lastEvent = event;
       }
 
       if (lastEvent) {
-        assert.ok(lastEvent.eventTime < endRounded);
+        assert.isTrue(lastEvent.eventTime < endRounded);
       }
     });
 
@@ -86,8 +86,8 @@ describe(
       }
       assert.equal(nextPage.value.events.length, maxPageSize);
       const event = nextPage.value.events[0];
-      assert.ok(event.eventType);
-      assert.ok(event.data.blobType);
+      assert.isDefined(event.eventType);
+      assert.isDefined(event.data.blobType);
 
       // continuationToken
       const iter1 = changeFeedClient
@@ -99,8 +99,8 @@ describe(
       }
       assert.equal(nextPage1.value.events.length, maxPageSize);
       const event1 = nextPage1.value.events[0];
-      assert.ok(event1.eventType);
-      assert.ok(event1.data.blobType);
+      assert.isDefined(event1.eventType);
+      assert.isDefined(event1.data.blobType);
       assert.notEqual(event1.id, event.id);
 
       // fetch between time range
@@ -115,16 +115,16 @@ describe(
       for await (const eventPage of iter2) {
         if (i++ === 0) {
           const firstEvent = eventPage.events[0];
-          assert.ok(firstEvent.eventType);
-          assert.ok(firstEvent.data.blobType);
+          assert.isDefined(firstEvent.eventType);
+          assert.isDefined(firstEvent.data.blobType);
           assert.notEqual(firstEvent.id, event.id);
         }
         lastEventPage = eventPage;
       }
 
       if (lastEventPage) {
         const lastEvent = lastEventPage.events[lastEventPage.events.length - 1];
-        assert.ok(lastEvent.eventTime < endRounded);
+        assert.isTrue(lastEvent.eventTime < endRounded);
       }
     });
 
@@ -166,7 +166,7 @@ describe(
         httpClient: MockHttpClient,
       });
       const telemetryString = await fetchTelemetryString(client);
-      assert.ok(telemetryString.startsWith(`changefeed-js/${SDK_VERSION}`));
+      assert.isTrue(telemetryString.startsWith(`changefeed-js/${SDK_VERSION}`));
       const blobServiceClient: BlobServiceClient = (changeFeedClient as any).blobServiceClient;
       const userAgentPrefix = "test/1 a b";
       const client2 = new BlobChangeFeedClient(
@@ -178,7 +178,7 @@ describe(
         },
       );
       const telemetryString2 = await fetchTelemetryString(client2);
-      assert.ok(telemetryString2.startsWith(`${userAgentPrefix} changefeed-js/${SDK_VERSION}`));
+      assert.isTrue(telemetryString2.startsWith(`${userAgentPrefix} changefeed-js/${SDK_VERSION}`));
     });
 
     it("tracing", async () => {
@@ -216,7 +216,7 @@ describe(
       } catch (err: any) {
         exceptionCaught = true;
       }
-      assert.ok(exceptionCaught);
+      assert.isDefined(exceptionCaught);
     });
   },
 );
@@ -312,7 +312,7 @@ describe(
         "2022-02-17T13:08:42.4825913Z",
         changeFeedEvent.data.previousInfo?.softDeleteSnapshot,
       );
-      assert.ok(changeFeedEvent.data.previousInfo?.isBlobSoftDeleted === true);
+      assert.isTrue(changeFeedEvent.data.previousInfo?.isBlobSoftDeleted);
       assert.equal(
         "2024-02-17T16:11:52.0781797Z",
         changeFeedEvent.data.previousInfo?.newBlobVersion,
@@ -439,7 +439,7 @@ describe(
         "2022-02-17T13:08:42.4825913Z",
         changeFeedEvent.data.previousInfo?.softDeleteSnapshot,
       );
-      assert.ok(changeFeedEvent.data.previousInfo?.isBlobSoftDeleted === true);
+      assert.isTrue(changeFeedEvent.data.previousInfo?.isBlobSoftDeleted);
       assert.equal(
         "2024-02-17T16:11:52.0781797Z",
         changeFeedEvent.data.previousInfo?.newBlobVersion,
@@ -525,7 +525,7 @@ describe(
       );
 
       assert.equal("Hot", changeFeedEvent.data.longRunningOperationInfo?.destinationAccessTier);
-      assert.ok(changeFeedEvent.data.longRunningOperationInfo?.isAsync === true);
+      assert.isTrue(changeFeedEvent.data.longRunningOperationInfo?.isAsync);
       assert.equal("copyId", changeFeedEvent.data.longRunningOperationInfo?.copyId);
     });
 
@@ -569,7 +569,7 @@ describe(
         "2022-02-17T13:12:11.5726507Z",
         changeFeedEvent.data.previousInfo?.softDeleteSnapshot,
       );
-      assert.ok(changeFeedEvent.data.previousInfo?.isBlobSoftDeleted === true);
+      assert.isTrue(changeFeedEvent.data.previousInfo?.isBlobSoftDeleted);
       assert.equal(
         "2024-02-17T16:11:52.0781797Z",
         changeFeedEvent.data.previousInfo?.newBlobVersion,
@@ -655,7 +655,7 @@ describe(
       );
 
       assert.equal("Hot", changeFeedEvent.data.longRunningOperationInfo?.destinationAccessTier);
-      assert.ok(changeFeedEvent.data.longRunningOperationInfo?.isAsync === true);
+      assert.isTrue(changeFeedEvent.data.longRunningOperationInfo?.isAsync);
       assert.equal("copyId", changeFeedEvent.data.longRunningOperationInfo?.copyId);
 
       assert.equal("Value1_3", changeFeedEvent.data.updatedBlobTags?.oldTags["Tag1"]);

sdk/storage/storage-blob-changefeed/test/changefeed.spec.ts

@@ -126,7 +126,7 @@ describe("Change Feed", async () => {
       return fakeList([]) as any;
     });
     const changeFeed = await changeFeedFactory.create(serviceClientStub);
-    assert.ok(!changeFeed.hasNext());
+    assert.isFalse(changeFeed.hasNext());
   });
 
   it("no years after start time", async () => {
@@ -143,7 +143,7 @@ describe("Change Feed", async () => {
     const changeFeed = await changeFeedFactory.create(serviceClientStub, undefined, {
       start: new Date(Date.UTC(2020, 0)),
     });
-    assert.ok(!changeFeed.hasNext());
+    assert.isFalse(changeFeed.hasNext());
   });
 
   it("no segments remaining in start year", async () => {
@@ -172,14 +172,14 @@ describe("Change Feed", async () => {
     const changeFeed = await changeFeedFactory.create(serviceClientStub, undefined, {
       start: new Date(Date.UTC(2019, 5)),
     });
-    assert.ok(!changeFeed.hasNext());
+    assert.isFalse(changeFeed.hasNext());
   });
 
   it("getChange", async () => {
     const changeFeed = await changeFeedFactory.create(serviceClientStub, undefined, {
       start: new Date(Date.UTC(2019, 0)),
     });
-    assert.ok(changeFeed.hasNext());
+    assert.isTrue(changeFeed.hasNext());
 
     const event = await changeFeed.getChange();
     assert.equal(event, 0 as unknown as BlobChangeFeedEvent | undefined);
@@ -189,14 +189,14 @@ describe("Change Feed", async () => {
       vi.mocked(segmentStubs[i].hasNext).mockReturnValue(false);
       vi.mocked(segmentStubs[i].getChange).mockResolvedValue(undefined);
     }
-    assert.ok(changeFeed.hasNext());
+    assert.isTrue(changeFeed.hasNext());
     const event2 = await changeFeed.getChange();
     assert.equal(event2, 2 as unknown as BlobChangeFeedEvent | undefined);
 
     // advanced to next year
     vi.mocked(segmentStubs[2].hasNext).mockReturnValue(false);
     vi.mocked(segmentStubs[2].getChange).mockResolvedValue(undefined);
-    assert.ok(changeFeed.hasNext());
+    assert.isTrue(changeFeed.hasNext());
     const event3 = await changeFeed.getChange();
     assert.equal(event3, 3 as unknown as BlobChangeFeedEvent | undefined);
 
@@ -205,7 +205,7 @@ describe("Change Feed", async () => {
     vi.mocked(segmentStubs[3].getChange).mockResolvedValue(undefined);
     const event4 = await changeFeed.getChange();
     assert.equal(event4, undefined);
-    assert.ok(!changeFeed.hasNext());
+    assert.isFalse(changeFeed.hasNext());
   });
 
   it("with start and end time", async () => {
@@ -214,14 +214,14 @@ describe("Change Feed", async () => {
       start: new Date(Date.UTC(2019, 2, 2, 21)),
       end: new Date(Date.UTC(2019, 3, 3, 22)),
     });
-    assert.ok(!changeFeed.hasNext());
+    assert.isFalse(changeFeed.hasNext());
 
     // end earlier than lastConsumable
     const changeFeed2 = await changeFeedFactory.create(serviceClientStub, undefined, {
       start: new Date(Date.UTC(2019, 3, 3, 22)),
       end: new Date(Date.UTC(2019, 4, 3, 22)),
     });
-    assert.ok(changeFeed2.hasNext());
+    assert.isTrue(changeFeed2.hasNext());
     const event = await changeFeed2.getChange();
     assert.equal(event, 1 as unknown as BlobChangeFeedEvent | undefined);
 
@@ -235,14 +235,14 @@ describe("Change Feed", async () => {
       start: lastConsumable,
       end: new Date(lastConsumable.getTime() + 1),
     });
-    assert.ok(!changeFeed3.hasNext());
+    assert.isFalse(changeFeed3.hasNext());
   });
 
   it("with continuation token", async () => {
     const changeFeed = await changeFeedFactory.create(serviceClientStub, undefined, {
       start: new Date(Date.UTC(2020, 2, 2, 20)),
     });
-    assert.ok(changeFeed.hasNext());
+    assert.isTrue(changeFeed.hasNext());
 
     const containerUri = "https://account.blob.core.windows.net/$blobchangefeed";
     (containerClientStub as any).url = containerUri;
@@ -256,7 +256,7 @@ describe("Change Feed", async () => {
     });
     const continuation = JSON.stringify(changeFeed.getCursor());
     const changeFeed2 = await changeFeedFactory.create(serviceClientStub, continuation);
-    assert.ok(changeFeed2.hasNext());
+    assert.isTrue(changeFeed2.hasNext());
     const event = await changeFeed.getChange();
     assert.equal(event, 3 as unknown as BlobChangeFeedEvent | undefined);
 
@@ -269,7 +269,7 @@ describe("Change Feed", async () => {
     vi.mocked(segmentStubs[3].hasNext).mockReturnValue(false);
     vi.mocked(segmentStubs[3].getChange).mockResolvedValue(undefined);
     const changeFeed3 = await changeFeedFactory.create(serviceClientStub, continuation);
-    assert.ok(changeFeed3.hasNext());
+    assert.isTrue(changeFeed3.hasNext());
     const event2 = await changeFeed3.getChange();
     assert.equal(event2, 4 as unknown as BlobChangeFeedEvent | undefined);
   });
@@ -279,6 +279,6 @@ describe("Change Feed", async () => {
       statusCode: 404,
     });
     const changeFeed = await changeFeedFactory.create(serviceClientStub, undefined);
-    assert.ok(!changeFeed.hasNext(), "Should return empty change feed");
+    assert.isFalse(changeFeed.hasNext(), "Should return empty change feed");
   });
 });

sdk/storage/storage-blob-changefeed/test/segment.spec.ts

@@ -59,7 +59,7 @@ describe("Segment", async () => {
   it("getChange round robin in shards", async () => {
     const segmentFactory = new SegmentFactory(shardFactoryStub);
     const segment = await segmentFactory.create(containerClientStub, manifestPath);
-    assert.ok(segment.hasNext());
+    assert.isTrue(segment.hasNext());
     assert.equal(segment.dateTime.getTime(), dateTime.getTime());
 
     // round robin
@@ -107,7 +107,7 @@ describe("Segment", async () => {
       SegmentPath: "idx/segments/2020/03/25/0200/meta.json",
       ShardCursors: [],
     } as any);
-    assert.ok(segment.hasNext());
+    assert.isTrue(segment.hasNext());
     assert.equal(segment.dateTime.getTime(), dateTime.getTime());
     const segmentCursor = segment.getCursor();
     assert.equal(segmentCursor.CurrentShardPath, CurrentShardPath);

sdk/storage/storage-blob/test/appendblobclient.spec.ts

@@ -76,11 +76,11 @@ describe("AppendBlobClient", () => {
 
   it("createIfNotExists", async () => {
     const res = await appendBlobClient.createIfNotExists();
-    assert.ok(res.succeeded);
-    assert.ok(res.etag);
+    assert.isTrue(res.succeeded);
+    assert.isDefined(res.etag);
 
     const res2 = await appendBlobClient.createIfNotExists();
-    assert.ok(!res2.succeeded);
+    assert.isFalse(res2.succeeded);
     assert.equal(res2.errorCode, "BlobAlreadyExists");
   });
 
@@ -175,7 +175,7 @@ describe("AppendBlobClient", () => {
       );
     }
 
-    assert.ok(exceptionCaught);
+    assert.isDefined(exceptionCaught);
   });
 
   it("Seal append blob", async () => {
@@ -189,7 +189,7 @@ describe("AppendBlobClient", () => {
     assert.deepStrictEqual(response.isSealed, true);
 
     for await (const item of containerClient.listBlobsFlat()) {
-      assert.ok(item.properties.isSealed);
+      assert.isDefined(item.properties.isSealed);
     }
   });