Skip to content

Chore: Add counterpart for GraphQL constants for tests #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
+15 −6
Merged

Chore: Add counterpart for GraphQL constants for tests #2558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions DatadogRUM/Tests/Instrumentation/Resources/URLSessionRUMResourcesHandlerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,10 +954,10 @@ class URLSessionRUMResourcesHandlerTests: XCTestCase {

// Given
var mockRequest: URLRequest = .mockWith(url: "https://graphql.example.com/api")
mockRequest.setValue("GetUser", forHTTPHeaderField: GraphQLHeaders.operationName)
mockRequest.setValue("query", forHTTPHeaderField: GraphQLHeaders.operationType)
mockRequest.setValue("{\"userId\":\"123\"}", forHTTPHeaderField: GraphQLHeaders.variables)
mockRequest.setValue("query GetUser($userId: ID!) { user(id: $userId) { name } }", forHTTPHeaderField: GraphQLHeaders.payload)
mockRequest.setValue("GetUser", forHTTPHeaderField: ExpectedGraphQLHeaders.operationName)
mockRequest.setValue("query", forHTTPHeaderField: ExpectedGraphQLHeaders.operationType)
mockRequest.setValue("{\"userId\":\"123\"}", forHTTPHeaderField: ExpectedGraphQLHeaders.variables)
mockRequest.setValue("query GetUser($userId: ID!) { user(id: $userId) { name } }", forHTTPHeaderField: ExpectedGraphQLHeaders.payload)

let immutableRequest = ImmutableRequest(request: mockRequest)
let taskInterception = URLSessionTaskInterception(request: immutableRequest, isFirstParty: false)
Expand Down Expand Up @@ -989,8 +989,8 @@ class URLSessionRUMResourcesHandlerTests: XCTestCase {

// Given
var mockRequest: URLRequest = .mockWith(url: "https://graphql.example.com/api")
mockRequest.setValue("FailedMutation", forHTTPHeaderField: GraphQLHeaders.operationName)
mockRequest.setValue("mutation", forHTTPHeaderField: GraphQLHeaders.operationType)
mockRequest.setValue("FailedMutation", forHTTPHeaderField: ExpectedGraphQLHeaders.operationName)
mockRequest.setValue("mutation", forHTTPHeaderField: ExpectedGraphQLHeaders.operationType)

let immutableRequest = ImmutableRequest(request: mockRequest)
let taskInterception = URLSessionTaskInterception(request: immutableRequest, isFirstParty: false)
Expand Down Expand Up @@ -1028,3 +1028,12 @@ class URLSessionRUMResourcesHandlerTests: XCTestCase {
return dict
}
}

// MARK: - Test Helpers

struct ExpectedGraphQLHeaders {
static let operationName: String = "_dd-custom-header-graph-ql-operation-name"
static let operationType: String = "_dd-custom-header-graph-ql-operation-type"
static let variables: String = "_dd-custom-header-graph-ql-variables"
static let payload: String = "_dd-custom-header-graph-ql-payload"
}