Add comment for skipped mongodb spec #4369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Datadog ReportBranch report: ✅ 0 Failed, 20100 Passed, 1363 Skipped, 3m 15.69s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4369 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 1352 1352
Lines 82734 82735 +1
Branches 4200 4200
=======================================
+ Hits 80818 80822 +4
+ Misses 1916 1913 -3 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2025-02-13 20:18:03 Comparing candidate commit 6c37ca0 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Propagation - Trace Context
|
sarahchen6
force-pushed
the
sarahchen6/unskip-mongodb-spec
branch
from
8f5c3bf to
420a110
Compare
sarahchen6
force-pushed
the
sarahchen6/unskip-mongodb-spec
branch
from
54af6b8 to
1846eed
Compare
zarirhamza
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a comment for why the mongodb spec is still skipped for GHA.
Motivation:
Tried to un-skip this spec, but resolving the underlying issue noted in the comment without a better solution would increase overhead by too much for this one spec. The goal is to eventually unskip this spec! We want to enable all tests for our migration to GHA: https://github.com/DataDog/ruby-guild/issues/214.
Change log entry
None.
Additional Notes:
Issue: https://github.com/DataDog/ruby-guild/issues/216.
How to test the change?
The PR change itself is just adding a comment. However, for the spec that is being skipped, it fails when running in a docker container (like for our GHA workflow) but passes when running locally.