Skip to content

Uncomment skips for sidekiq, crashtracking, and telemetry specs. #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Uncomment skips for sidekiq, crashtracking, and telemetry specs. #4374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ name: Unit Tests
push:
branches:
- master
- sarahchen6/*
pull_request:
branches:
- master
Expand Down
4 changes: 2 additions & 2 deletions spec/datadog/core/crashtracking/component_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@
let(:agent_base_url) { "http://#{hostname}:#{port}" }

[:fiddle, :signal].each do |trigger|
it "reports crashes via http when app crashes with #{trigger}", skip: ENV['BATCHED_TASKS'] do
it "reports crashes via http when app crashes with #{trigger}" do
fork_expectations = proc do |status:, stdout:, stderr:|
expect(Signal.signame(status.termsig)).to eq('SEGV').or eq('ABRT')
expect(stderr).to include('[BUG] Segmentation fault')
Expand Down Expand Up @@ -269,7 +269,7 @@
# Do nothing, it's ok
end

it 'reports crashes via uds when app crashes with fiddle', skip: ENV['BATCHED_TASKS'] do
it 'reports crashes via uds when app crashes with fiddle' do
fork_expectations = proc do |status:, stdout:, stderr:|
expect(Signal.signame(status.termsig)).to eq('SEGV').or eq('ABRT')
expect(stderr).to include('[BUG] Segmentation fault')
Expand Down
8 changes: 4 additions & 4 deletions spec/datadog/core/telemetry/component_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
end
end

context 'when in fork', skip: ENV['BATCHED_TASKS'] do
context 'when in fork' do
before { skip 'Fork not supported on current platform' unless Process.respond_to?(:fork) }

it do
Expand Down Expand Up @@ -169,7 +169,7 @@
end
end

context 'when in fork', skip: ENV['BATCHED_TASKS'] do
context 'when in fork' do
before { skip 'Fork not supported on current platform' unless Process.respond_to?(:fork) }

it do
Expand Down Expand Up @@ -209,7 +209,7 @@
end
end

context 'when in fork', skip: ENV['BATCHED_TASKS'] do
context 'when in fork' do
before { skip 'Fork not supported on current platform' unless Process.respond_to?(:fork) }

it do
Expand Down Expand Up @@ -245,7 +245,7 @@
expect(worker).to have_received(:enqueue).with(event)
end

context 'when in fork', skip: !Process.respond_to?(:fork) || ENV['BATCHED_TASKS'] do
context 'when in fork', skip: !Process.respond_to?(:fork) do
it do
telemetry
expect_in_fork do
Expand Down
2 changes: 1 addition & 1 deletion spec/datadog/tracing/contrib/sidekiq/server_internal_tracer/heartbeat_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'datadog/tracing/contrib/support/spec_helper'
require_relative '../support/helper'

RSpec.describe 'Server internal tracer heartbeat', skip: ENV['BATCHED_TASKS'] do
RSpec.describe 'Server internal tracer heartbeat' do
include SidekiqServerExpectations

before do
Expand Down
2 changes: 1 addition & 1 deletion spec/datadog/tracing/contrib/sidekiq/server_internal_tracer/job_fetch_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'datadog/tracing/contrib/support/spec_helper'
require_relative '../support/helper'

RSpec.describe 'Server internal tracer', skip: ENV['BATCHED_TASKS'] do
RSpec.describe 'Server internal tracer' do
include SidekiqServerExpectations

before do
Expand Down
2 changes: 1 addition & 1 deletion spec/datadog/tracing/contrib/sidekiq/server_internal_tracer/redis_info_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'datadog/tracing/contrib/support/spec_helper'
require_relative '../support/helper'

RSpec.describe 'Server internal tracer', skip: ENV['BATCHED_TASKS'] do
RSpec.describe 'Server internal tracer' do
include SidekiqServerExpectations
before do
unless Datadog::Tracing::Contrib::Sidekiq::Integration.compatible_with_server_internal_tracing?
Expand Down
2 changes: 1 addition & 1 deletion spec/datadog/tracing/contrib/sidekiq/server_internal_tracer/scheduled_poller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'datadog/tracing/contrib/support/spec_helper'
require_relative '../support/helper'

RSpec.describe 'Server internal tracer', skip: ENV['BATCHED_TASKS'] do
RSpec.describe 'Server internal tracer' do
include SidekiqServerExpectations

before do
Expand Down
9 changes: 6 additions & 3 deletions tasks/github.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ namespace :github do
'push' => {
'branches' => [
'master',
'sarahchen6/*'
]
},
'pull_request' => {
Expand Down Expand Up @@ -340,11 +341,13 @@ namespace :github do
matrix = eval(File.read('Matrixfile')).freeze # rubocop:disable Security/Eval

exceptions = [
# 'sidekiq', # Connection refused - connect(2) for 127.0.0.1:6379 (RedisClient::CannotConnectError)
'sidekiq',
'crashtracking',
'main'
]

# candidates = exceptions
candidates = matrix.keys - exceptions
candidates = exceptions
# candidates = matrix.keys - exceptions

raise 'No candidates.' if candidates.empty?

Expand Down
Loading