-
Notifications
You must be signed in to change notification settings - Fork 398
Add option to override span events serialization #4507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 20663 Passed, 1371 Skipped, 3m 10.93s Total Time |
dd4cbf1 to
724f090
Compare
724f090 to
2a04a1d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4507 +/- ##
==========================================
- Coverage 97.70% 97.70% -0.01%
==========================================
Files 1381 1381
Lines 83973 84106 +133
Branches 4251 4253 +2
==========================================
+ Hits 82043 82172 +129
- Misses 1930 1934 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ivoanjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
maycmlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small suggestion and question.
Co-authored-by: May Lee <[email protected]>
maycmlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcotc thanks for the explanation! just a small suggestion, but going to approve to not block this.
Co-authored-by: May Lee <[email protected]>
For agent-less setups, when native support is desired (e.g. the downstream agent supports native span events), this PR adds an option to override the agent decision and send native span events regardless of the environment.
Change log entry
Yes. Add an option to override span events serialization for agent-less environments.
How to test the change?
There are unit tests, and this change will allow to better coverage in parametric tests.