Skip to content

Conversation

@marcotc
Copy link
Member

@marcotc marcotc commented Mar 18, 2025

For agent-less setups, when native support is desired (e.g. the downstream agent supports native span events), this PR adds an option to override the agent decision and send native span events regardless of the environment.

Change log entry
Yes. Add an option to override span events serialization for agent-less environments.

How to test the change?
There are unit tests, and this change will allow to better coverage in parametric tests.

@marcotc marcotc requested review from a team as code owners March 18, 2025 00:50
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 18, 2025

Datadog Report

Branch report: ruby-option-span-events
Commit report: 43805f5
Test service: dd-trace-rb

✅ 0 Failed, 20663 Passed, 1371 Skipped, 3m 10.93s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 18, 2025

Benchmarks

Benchmark execution time: 2025-03-19 00:43:30

Comparing candidate commit 43805f5 in PR branch ruby-option-span-events with baseline commit 7d88b81 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@marcotc marcotc force-pushed the ruby-option-span-events branch from dd4cbf1 to 724f090 Compare March 18, 2025 01:33
@marcotc marcotc force-pushed the ruby-option-span-events branch from 724f090 to 2a04a1d Compare March 18, 2025 01:40
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.70%. Comparing base (7d88b81) to head (43805f5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4507      +/-   ##
==========================================
- Coverage   97.70%   97.70%   -0.01%     
==========================================
  Files        1381     1381              
  Lines       83973    84106     +133     
  Branches     4251     4253       +2     
==========================================
+ Hits        82043    82172     +129     
- Misses       1930     1934       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@maycmlee maycmlee self-assigned this Mar 18, 2025
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion and question.

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcotc thanks for the explanation! just a small suggestion, but going to approve to not block this.

@marcotc marcotc requested a review from a team as a code owner March 19, 2025 00:18
@marcotc marcotc merged commit a04dfda into master Mar 19, 2025
461 of 462 checks passed
@marcotc marcotc deleted the ruby-option-span-events branch March 19, 2025 16:48
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 19, 2025
@vpellan vpellan mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants