-
Notifications
You must be signed in to change notification settings - Fork 398
chore(logging): enable 128bit trace id logging by default #4528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md(possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None.(possible answers No/Nope/None) Visited at: 2025-03-19 20:13:55 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 20779 Passed, 1373 Skipped, 3m 11.3s Total Time |
BenchmarksBenchmark execution time: 2025-03-27 18:56:33 Comparing candidate commit 5c65c0c in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Tracing.log_correlation
|
TonyCTHsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing default is not trivia, how does this change going to impact current users?
This is a change we are rolling out across all client libraries. Ruby and PHP are the last set of libraries to receive this change. This change should not impact customers using Datadog log pipelines. Datadog log pipelines fully support correlating logs to traces using both 64bit and 128bit trace ids. This change could impact customers who export their logs to other providers. This is an edge case we are okay with. |
c685ac2 to
d685456
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4528 +/- ##
==========================================
+ Coverage 97.75% 97.76% +0.01%
==========================================
Files 1386 1392 +6
Lines 84299 84899 +600
Branches 4259 4279 +20
==========================================
+ Hits 82404 83005 +601
+ Misses 1895 1894 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do?
DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLEDtoTrue.Motivation:
Ensures the full 128bit trace ids are injected into logs instead of just the lower order 64bits. This ensures the logs injected into traces is consistent with the trace id shown in the Datadog UI.
Change log entry
Updates the default value of DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED to True, ensuring logs contain the full 128-bit trace ID for consistency with the trace ID displayed in the Datadog UI.
Additional Notes:
How to test the change?