Skip to content

Fix method override warning in profiler #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
p-datadog merged 2 commits into from
Mar 31, 2025
Merged

Fix method override warning in profiler #4549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6414812
Fix method override warning in profiler
p Mar 31, 2025
d9d6e4a
rubocop, this method is still defined nestedly
p Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/datadog/profiling.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,11 @@ def self.wait_until_running(timeout_seconds: 5)
end

private_class_method def self.replace_noop_allocation_count
def self.allocation_count # rubocop:disable Lint/NestedMethodDefinition (On purpose!)
Datadog::Profiling::Collectors::CpuAndWallTimeWorker._native_allocation_count
class << self
remove_method :allocation_count
def allocation_count
Datadog::Profiling::Collectors::CpuAndWallTimeWorker._native_allocation_count
end
end
end

Expand Down
Loading