[NO-TICKET] Add baggage to karafka list of propagation styles #4614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4614 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 1415 1417 +2
Lines 86264 86316 +52
Branches 4348 4348
=======================================
+ Hits 84339 84390 +51
- Misses 1925 1926 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Datadog ReportBranch report: ✅ 0 Failed, 21261 Passed, 1373 Skipped, 3m 40.27s Total Time |
BenchmarksBenchmark execution time: 2025-05-02 09:54:56 Comparing candidate commit ef4dd71 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Tracing.log_correlation
|
p-datadog
approved these changes
Apr 29, 2025
marcotc
approved these changes
Apr 29, 2025
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
May 5, 2025
* telemetry-integration-test: (21 commits) fix test cleanup fix test setup try a non-zero timeout? fix integration test Update spec/datadog/core/telemetry/integration/telemetry_spec.rb fix other test fix flushing flush telemetry events fix test provide a block rubocop rubocop di add content-type assertion wait for thread to end telemetry integration test do not initialize components from on fork handler Emtpy string Bump the gh-actions-packages group across 2 directories with 4 updates [APMAPI-1258] Adjust trace sampling formula (DataDog#4616) Add baggage to karafka list of propagation styles (DataDog#4614) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds baggage to karafka list of propagation styles.
Motivation:
There's a lot of telemetry spam about the tracer trying to call inject! on nil. One of the reason this happens is that we don't have baggage in karafka list of propagation style. When mapping the list of default propagation style, it maps the baggage one to nil, which causes the tracer to call inject! on nil later on.
Change log entry
Yes. Fix Karafka logger and telemetry spam caused by distributed tracing.
Additional Notes:
How to test the change?
CI.