Skip to content

Conversation

@y9v
Copy link
Member

@y9v y9v commented Oct 6, 2025

What does this PR do?
This PR adds Endpoint Collection feature for AppSec.

Motivation:
We want to collect routing information for Rails apps even for endpoints that don't get traffic.

Change log entry
None. This is internal change.

Additional Notes:
This PR fixes flakyness in the integration test by adding Devise.

APPSEC-59522

How to test the change?
CI

@y9v y9v self-assigned this Oct 6, 2025
@y9v y9v requested review from a team as code owners October 6, 2025 15:28
@github-actions github-actions bot added core Involves Datadog core libraries integrations Involves tracing integrations appsec Application Security monitoring product labels Oct 6, 2025
@datadog-official
Copy link

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.59%
Total Coverage: 101.95% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c126aa1 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 6, 2025

Benchmarks

Benchmark execution time: 2025-10-06 16:00:22

Comparing candidate commit c126aa1 in PR branch appsec-enable-endpoint-collection-v2 with baseline commit 49a5c68 in branch master.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+11019.632op/s; +11628.362op/s] or [+7.706%; +8.131%]

scenario:method instrumentation

  • 🟩 throughput [+10311.290op/s; +10849.409op/s] or [+6.271%; +6.599%]

scenario:profiling - intern_all 1000 repeated strings

  • 🟥 throughput [-1319.480op/s; -1256.835op/s] or [-5.466%; -5.207%]

@y9v y9v merged commit ebd7acc into master Oct 8, 2025
357 of 358 checks passed
@y9v y9v deleted the appsec-enable-endpoint-collection-v2 branch October 8, 2025 14:30
@github-actions github-actions bot added this to the 2.22.0 milestone Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants